Just a few questions...

No I don't have access to that file.

The Last time something like this occurred, we had a "Pages with too many expensive parser function calls. " coming from Template:SkillNav calling Template:IconLink too many times. How it was fixed was beyond me.

Can you give me an example of an equipment page? I looked a recent ones and didn't see 1000 character error.

Dfoplayer (talk)

Luberum Stone Fall was one of the pages a few of the editors were discussing about. They decided to separate the information outside the page template to avoid the issue. To replicate this error, just copy the information under the Description heading and paste it within the description parameter.

Altair (talk)

I don't think it's a parser function problem. If you looked at the the bottom, the 1000 character limit also affects semantic properties.

I have disabled property "Has effect description" for the equipment template. I don't think we will be searching descriptions, just numbers(levels) or class requirements.

It could take awhile for the server to update semantics, as I still see the error while editing Luberum Stone Fall. Try again tomorrow.

Dfoplayer (talk)

Alright. It wasn't semantics.

It is probably Parser functions. The equipment template is trying to replace asterisks(*) with the HTML equivalent from code {{#replace:{{{description}}}|*|& #42;}} and we are sending over 1000 characters.

I would suggest you send a message to User:Gardios to ask why he/she used a replace function. Maybe description with asterisks fails in the template, so Gardios wanted HTML

Dfoplayer (talk)

I messaged him on Discord, but I don't expect a response anytime soon. I don't believe he plays DFO or goes to the wiki anymore.

Altair (talk)

Poo. While I can go contact the site admin, she probably will ask if we can workaround this. For security reasons, it should be set to low as possible.

If she does allow us to change $wgPFStringLenghtLimit, do you have a number we should set to? I'm thinking maybe 15,000 since this is a description.

We also should figure out why replace is being used, cause removing that in the template might solve our problem. reference edit

Dfoplayer (talk)

I figured out why #replace is being used in description. I believe that it is to prevent asterisks from creating bulleted lists in the descriptions. Look at Light Sword Masamune for reference. Most equipment pages don't use asterisks in their description so this probably isn't the problem.

Anyway, I think I figured out what's going wrong. I did some tests with the Luberum Stone Fall page.

My first test involved removing all the Template:IconLink calls in the description. The page didn't return an error.

For my second test, I gradually changed some of the links to use IconLink; it worked up to three calls. At the fourth call, the String Error occurred.

My third test involved attempting to exceed the string limit without IconLink. I used the following as a test:

[[War Goddess]] additional Bloodsport/Magic Skill Atk. +6%


[[Neutral Chaser]] Atk. +15%<br>
[[Light Chaser]] Atk. +15%<br>
[[Water Chaser]] Atk. +15%<br>
[[Fire Chaser]] Atk. +15%<br>
[[Shadow Chaser]] Atk. +15%<br>


[[Fusion Chaser]] Atk. change value +35%<br>
Generated Chasers increase Attack/Movement/Casting Speeds +4% for 20 seconds. (Canceled when the item is unequipped. Max Stack: 3 Cooldown: 1 sec.)<br>
[[Twinkle Smash]] Atk. +10%


[[Relentless Biting Wind]] Atk. and Hold duration +15%<br>
[[Sweeping Wind]] wind attack count +2<br>
[[Eye of the Storm]] Atk. +15%<br>
[[Northern Wind]] wind attack count +2

[[Relentless Biting Wind]], [[Sweeping Wind]] and [[Headwind]] increases STR +150 for 60 seconds. (Max Stacks: 1. Canceled when the item is unequipped. Max Stack: 3 Cooldown: 1 sec.)

ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss
ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss
ss

The current string has 999 characters. Adding one more 's' character will cause the string to reach 1000 characters and return an error. Apparently, the description parameter has a limit of 1000 characters.

For this page in particular, I believe what's causing the issue is the Template: IconLink. IconLink replaces the page link to include the image link of it as well, which results in a longer string depending on the image name.

That being said, we have two options:

1) We can remove the IconLink calls from the descriptions

2) We can increase the string limit to somewhere in-between 1500-2000.

Altair (talk)

Well, back when DFO wiki was being revamped, we did have an issue with Template:IconLink. But it shouldn't cause a problem with 1000 characters. Otherwise, Skill pages would fail too.

To test, I copied Luberum Stone Fall's description to skill page description and it renders perfectly. This leads me to something else has a problem on Template:EquipmentInfo.

Gardios did leave a comment that "write skill bonuses, legacy bonuses, description and flavor text into the var 'effects' ". So the variable 'effects' might be exceeding 1000 characters. Further testing needs to be done though...

Dfoplayer (talk)

Alright. It's working now.

Go ahead and edit any of the pages that are failing, I tested Luberum Stone Fall. Preview the template User:Dfoplayer/TestEquipmentInfo by changing {{Equipment infobox to {{User:Dfoplayer/TestEquipmentInfo

If it looks good, we can move the changes to the live template and let the other editors know that description can have the full text back.

Dfoplayer (talk)

Worked for this

http://wiki.dfo.world/view/Savior%27s_Glory_-_Cross

Arrol (talk)

Alright. I'll go ahead and push the changes to the actual template.

Dfoplayer (talk)